When in high school, my guidance counselor talked to me about career options. what kind of error does this sentence have?

I'd say that this sentence has a dangling or misplaced modifier.

The modifier when in highschool cannot be used that way, because we don't know for sure whether that refers to the guidance counselor or you. The correct way to write this sentence would be:

When I was in high school, ...